Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
@DN6 a gentle ping. |
DN6
reviewed
Apr 14, 2026
Comment on lines
344
to
+362
| @@ -362,10 +359,7 @@ def test_stable_diffusion_decode_xformers_vs_2_0_fp16(self, seed): | |||
|
|
|||
| @parameterized.expand([(13,), (16,), (37,)]) | |||
| @require_torch_gpu | |||
| @unittest.skipIf( | |||
| not is_xformers_available(), | |||
| reason="xformers is not required when using PyTorch 2.0.", | |||
| ) | |||
| @pytest.mark.skipif(not is_xformers_available(), reason="xformers is not required when using PyTorch 2.0.") | |||
Collaborator
There was a problem hiding this comment.
Why don't we remove these xformers tests? They're not as relevant and we rely on set_attention_backend for this functionality.
Member
Author
There was a problem hiding this comment.
Do we support set_attention_backend() on AutoencoderKL? I don't think we do.
I don't think this was a merge blocker 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.